Commit Graph

1184 Commits

Author SHA1 Message Date
justsisyphus
ea1d604b72 chore(index): remove contextInjector chat.message hook call
- Remove createContextInjectorHook from imports
- Remove contextInjector variable declaration
- Remove contextInjector["chat.message"] call
- Keep contextInjectorMessagesTransform for synthetic part injection
- Update test: prepend → synthetic part insertion verification
2026-01-16 18:31:08 +09:00
justsisyphus
d3e3371a77 refactor(context-injector): remove chat.message hook, insert synthetic part in transform
- Remove injectPendingContext function (no longer needed)
- Remove createContextInjectorHook function (chat.message hook removed)
- Change transform hook from prepend to synthetic part insertion
- Follow empty-message-sanitizer pattern (minimal field set)
- synthetic: true flag hides content from UI but passes to model
- Synthetic part inserted BEFORE user text part
2026-01-16 18:31:08 +09:00
justsisyphus
188bbef018 refactor: rename sisyphus_task to delegate_task
- Rename directories: sisyphus-task → delegate-task
- Rename types: SisyphusTaskArgs → DelegateTaskArgs, etc.
- Rename functions: createSisyphusTask → createDelegateTask
- Rename constants: SISYPHUS_TASK_* → DELEGATE_TASK_*
- Update tool name: sisyphus_task → delegate_task
- Update all prompts, docs, and tests
2026-01-16 18:31:08 +09:00
justsisyphus
6008388a4e feat(prometheus): auto-generate plan workflow with self-review
- Remove intermediate questions before plan generation
- Auto-proceed with Metis consultation
- Generate plan immediately after Metis review
- Add Post-Plan Self-Review with gap classification:
  - CRITICAL: requires user input
  - MINOR: auto-resolve silently
  - AMBIGUOUS: apply default and disclose
- Present summary with auto-resolved items and decisions needed
- Ask high accuracy question after summary
2026-01-16 18:31:08 +09:00
github-actions[bot]
880e29e883 @minkichoe-lbox has signed the CLA in code-yeongyu/oh-my-opencode#847 2026-01-16 09:14:31 +00:00
justsisyphus
e23ce11df9 feat: allow Sisyphus-Junior to call sisyphus_task 2026-01-16 17:14:31 +09:00
justsisyphus
f1cdb3bce1 feat: global sisyphus_task deny with orchestrator exceptions
- Add sisyphus_task: deny to global config.permission
- Add sisyphus_task: allow exception for orchestrator-sisyphus, Sisyphus, and Prometheus (Planner)
- Ensures only orchestrator agents can spawn sisyphus_task subagents
2026-01-16 17:13:08 +09:00
justsisyphus
83cbc56709 refactor: remove legacy tools format, use permission only
BREAKING: Requires OpenCode 1.1.1+

- Remove supportsNewPermissionSystem/usesLegacyToolsSystem checks
- Simplify permission-compat.ts to permission format only
- Unify explore/librarian deny lists: write, edit, task, sisyphus_task, call_omo_agent
- Add sisyphus_task to oracle deny list
- Update agent-tool-restrictions.ts with correct per-agent restrictions
- Clean config-handler.ts conditional version checks
- Update tests for simplified API
2026-01-16 17:11:34 +09:00
justsisyphus
ede9abceb3 feat(multimodal-looker): restrict to read-only tool access
Use createAgentToolAllowlist to allow only 'read' tool for multimodal-looker agent.
Previously denied write/edit/bash but allowed other tools.
Now uses wildcard deny pattern (*: deny) with explicit read allow.

- Add createAgentToolAllowlist function for allowlist-based restrictions
- Support legacy fallback for older OpenCode versions
- Add 4 test cases covering both permission systems
2026-01-16 15:02:55 +09:00
justsisyphus
27ef9fa8df feat(orchestrator): emphasize project-level lsp_diagnostics and QA verification
- Add mandatory PROJECT-LEVEL code checks (lsp_diagnostics at src/ or . level)
- Strengthen verification duties with explicit QA checklist
- Add 'SUBAGENTS LIE - VERIFY EVERYTHING' reminders throughout
- Emphasize that only orchestrator sees full picture of cross-file impacts
2026-01-16 14:11:56 +09:00
justsisyphus
333db56172 refactor(agents): remove lsp_diagnostics from Sisyphus and Sisyphus-Junior prompts
Orchestrator Sisyphus will handle project-level code validation instead of
having each subagent run file-level lsp_diagnostics.
2026-01-16 14:09:28 +09:00
justsisyphus
1ecb2bafdf fix(hooks): prevent start-work false trigger from command description
- Remove 'Start Sisyphus work session' text check, keep only <session-context> tag
- Update interactive_bash description with WARNING: TMUX ONLY emphasis
- Update tests to use <session-context> wrapper
2026-01-16 14:01:29 +09:00
justsisyphus
d00c2e7439 fix(hooks): extract model from assistant messages with flat modelID/providerID
OpenCode API returns different structures for user vs assistant messages:
- User: info.model = { providerID, modelID } (nested)
- Assistant: info.modelID, info.providerID (flat top-level)

Previous code only checked nested format, causing model info loss when
continuation hooks fired after assistant messages.

Files modified:
- todo-continuation-enforcer.ts
- ralph-loop/index.ts
- sisyphus-task/tools.ts
- background-agent/manager.ts

Added test for assistant message model extraction.
2026-01-16 13:54:22 +09:00
justsisyphus
8d545723dc refactor(orchestrator): restructure post-verification workflow as Step 4-6
- Unified verification (Step 1-3) and post-verification (Step 4-6) into continuous workflow
- Step 4: Immediate plan file marking after verification passes
- Step 5: Commit atomic unit
- Step 6: Proceed to next task
- Emphasized immediacy: 'RIGHT NOW - Do not delay'
- Applied to both boulder state and standalone reminder contexts
2026-01-16 13:48:18 +09:00
justsisyphus
e737477fbe feat(prometheus): strengthen plan-mode constraints with constraint-first architecture
- Move Turn Termination Rules inside <system-reminder> block (from line 488 to ~186)
- Add Final Constraint Reminder at end of prompt (constraint sandwich pattern)
- Preserve all existing interview mode detail and strategies

Applies OpenCode's effective constraint patterns to prevent plan-mode agents
from offering to implement work instead of staying in consultation mode.
2026-01-16 13:36:46 +09:00
justsisyphus
aa859f8cdd feat(sisyphus-task): require explicit skills parameter - reject empty array []
- Change skills type from string[] to string[] | null
- Empty array [] now returns error with available skills list
- null is allowed for tasks that genuinely need no skills
- Updated tests to use skills: null instead of skills: []
- Forces explicit decision: either specify skills or justify with null
2026-01-16 13:12:48 +09:00
justsisyphus
c282244439 fix: store session agent in chat.message for prometheus-md-only hook
The prometheus-md-only hook was not enforcing file restrictions because
getSessionAgent() returned undefined - setSessionAgent was only called
in message.updated event which doesn't always provide agent info.

- Add setSessionAgent call in chat.message hook when input.agent exists
- Add session state tests for setSessionAgent/getSessionAgent
- Add clearSessionAgent cleanup to prometheus-md-only tests

This ensures prometheus-md-only hook can reliably identify Prometheus
sessions and enforce .sisyphus/*.md write restrictions.
2026-01-16 11:35:37 +09:00
justsisyphus
75925d5433 fix: clear session agent on /start-work to allow mode transition from Prometheus
When transitioning from Prometheus (Planner) to Sisyphus via /start-work,
the session agent was not being cleared. This caused prometheus-md-only
hook to continue injecting READ-ONLY constraints into sisyphus_task calls.

- Add clearSessionAgent() call when start-work command is detected
- Add TDD test verifying clearSessionAgent is called with sessionID
2026-01-16 11:35:37 +09:00
justsisyphus
c7ca608b38 refactor: unify system directive prefix for keyword-detector filtering
- Add shared/system-directive.ts with SYSTEM_DIRECTIVE_PREFIX constant
- Unify all system message prefixes to [SYSTEM DIRECTIVE: OH-MY-OPENCODE - ...]
- Add isSystemDirective() filter to keyword-detector to skip system messages
- Update prometheus-md-only tests to use new prefix constants
2026-01-16 11:35:37 +09:00
justsisyphus
b933992e36 refactor: remove dcp_for_compaction and preemptive_compaction features
- Delete src/hooks/preemptive-compaction/ entirely
- Remove dcp_for_compaction from schema and executor
- Clean up related imports, options, and test code
- Update READMEs to remove experimental options docs
2026-01-16 11:35:37 +09:00
justsisyphus
bf28b3e711 fix: ensure Sisyphus agent has call_omo_agent disabled
The tools restriction was defined in sisyphus.ts but not enforced in
config-handler.ts like other agents (orchestrator-sisyphus, Prometheus).
Added explicit tools setting to guarantee call_omo_agent is disabled.
2026-01-16 11:35:37 +09:00
justsisyphus
9363324e0e refactor(lsp): clean up lsp_servers references and update prompts to use PascalCase
- Remove dead lsp_servers function from tools.ts
- Update utils.ts to reference LspServers (OpenCode built-in)
- Update AGENTS.md: 7 tools → 3 tools
- Update init-deep.ts prompts to use PascalCase OpenCode tools
- Update refactor.ts prompts to use PascalCase OpenCode tools
2026-01-16 11:35:37 +09:00
Kenny
f888da8848 Merge pull request #833 from KNN-07/fix/git-master-watermark-injection
fix(git-master): inject watermark only when enabled instead of overriding defaults
2026-01-15 20:36:18 -05:00
justsisyphus
9fb284d4b5 docs: update LSP tools list in all READMEs
Remove OpenCode built-in tools (lsp_goto_definition, lsp_find_references, lsp_symbols, lsp_servers) that are not provided by oh-my-opencode. Keep only lsp_diagnostics, lsp_prepare_rename, lsp_rename.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:33:55 +09:00
justsisyphus
584aecf266 refactor(config): disable unused OpenCode built-in LSP tools
LspHover, LspCodeActions, LspCodeActionResolve are disabled globally as they are not needed when using oh-my-opencode's curated LSP tools.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:33:44 +09:00
justsisyphus
848b2e3faa refactor(lsp): remove lsp_servers - duplicates OpenCode's LspServers
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:33:35 +09:00
justsisyphus
33666245d8 docs: remove OpenCode built-in LSP tools from README
lsp_goto_definition, lsp_find_references, lsp_symbols are provided by OpenCode, not oh-my-opencode. Keep only the 4 tools we actually provide: lsp_diagnostics, lsp_servers, lsp_prepare_rename, lsp_rename.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:25:49 +09:00
Nguyen Khac Trung Kien
e36385e671 fix(git-master): inject watermark only when enabled instead of overriding defaults
The watermark (commit footer and co-author) was inconsistently applied because:
1. The skill tool didn't receive gitMasterConfig
2. The approach was 'default ON, inject DISABLED override' which LLMs sometimes ignored

This refactors to 'inject only when enabled' approach:
- Remove hardcoded watermark section from base templates
- Dynamically inject section 5.5 based on config values
- Default is still ON (both true when no config)
- When both disabled, no injection occurs (clean prompt)

Also fixes missing config propagation to skill tool and createBuiltinAgents.
2026-01-16 08:01:04 +07:00
Jeremy Gollehon
837176d947 Merge pull request #803 from GollyJer/concurrency-hardening
feat(concurrency): prevent background task races and leaks

Summary
Fixes race conditions and memory leaks in the background task system that could cause "all tasks complete" notifications to never fire, leaving parent sessions waiting indefinitely.

Why This Change?
When background tasks are tracked for completion notifications, the system maintains a pendingByParent map to know when all tasks for a parent session are done. Several edge cases caused "stale entries" to accumulate in this map:
1. Re-registering completed tasks added them back to pending tracking, but they'd never complete again
2. Changing a task's parent session left orphan entries in the old parent's tracking set
3. Concurrent task operations could cause double-acquisition of concurrency slots
These bugs meant the system would sometimes wait forever for tasks that were already done.

What Changed
- Concurrency management: Added proper acquire/release lifecycle with cleanup on process exit (SIGINT, SIGTERM)
- Parent session tracking: Fixed cleanup order. Now clears old parent's tracking before updating parent ID
- Stale entry prevention: Only tracks tasks that are actually running; actively cleans up completed tasks
- Renamed registerExternalTask → trackTask: Clearer name (the old name implied external API consumers, but it's internal)
2026-01-15 11:09:52 -08:00
Jeremy Gollehon
8e2410f1a0 refactor(background-agent): rename registerExternalTask to trackTask
Update BackgroundManager to rename the method for tracking external tasks, improving clarity and consistency in task management. Adjust related tests to reflect the new method name.
2026-01-15 10:53:08 -08:00
github-actions[bot]
bad98e88ec release: v3.0.0-beta.8 v3.0.0-beta.8 2026-01-15 17:50:06 +00:00
justsisyphus
e264cd5078 test: skip flaky timeout test in CI 2026-01-16 02:45:41 +09:00
justsisyphus
0230e71bc6 fix(ci): skip platform packages for now (OIDC not configured) 2026-01-16 02:38:26 +09:00
justsisyphus
c9f762f980 fix(hooks): use API instead of filesystem to resolve model info for session.prompt
Previously, continuation hooks (todo-continuation, boulder-continuation, ralph-loop)
and background tasks resolved model info from filesystem cache, which could be stale
or missing. This caused session.prompt to fallback to default model (Sonnet) instead
of using the originally configured model (e.g., Opus).

Now all session.prompt calls first try API (session.messages) to get current model
info, with filesystem as fallback if API fails.

Affected files:
- todo-continuation-enforcer.ts
- sisyphus-orchestrator/index.ts
- ralph-loop/index.ts
- background-agent/manager.ts
- sisyphus-task/tools.ts
- hook-message-injector/index.ts (export ToolPermission type)
2026-01-16 02:33:44 +09:00
justsisyphus
f658544cd6 fix(ci): add NPM_TOKEN for npm publish authentication 2026-01-16 02:31:12 +09:00
justsisyphus
396043a122 fix(ci): add registry-url to setup-node for OIDC auth 2026-01-16 02:25:51 +09:00
justsisyphus
9854e9f6e5 Revert "fix(ci): add NPM_TOKEN support for npm publishing"
This reverts commit 5de3d4fb7d.
2026-01-16 02:20:15 +09:00
justsisyphus
48167a6920 refactor(lsp): remove duplicate LSP tools already provided by OpenCode
Remove lsp_goto_definition, lsp_find_references, lsp_symbols as they
duplicate OpenCode's built-in LspGotoDefinition, LspFindReferences,
LspDocumentSymbols, and LspWorkspaceSymbols.

Keep oh-my-opencode-specific tools:
- lsp_diagnostics (OpenCode lacks pull diagnostics)
- lsp_servers (server management)
- lsp_prepare_rename / lsp_rename (OpenCode lacks rename)

Clean up associated dead code:
- Client methods: hover, definition, references, symbols, codeAction
- Utils: formatLocation, formatSymbolKind, formatDocumentSymbol, etc.
- Types: Location, LocationLink, SymbolInfo, DocumentSymbol, etc.
- Constants: SYMBOL_KIND_MAP, DEFAULT_MAX_REFERENCES/SYMBOLS

-418 lines removed.
2026-01-16 02:17:00 +09:00
justsisyphus
207a39b17a fix(skill): unify skill resolution to support user custom skills
sisyphus_task was only loading builtin skills via resolveMultipleSkills().
Now uses resolveMultipleSkillsAsync() which merges discoverSkills() + builtin skills.

- Add getAllSkills(), extractSkillTemplate(), resolveMultipleSkillsAsync()
- Update sisyphus_task to use async skill resolution
- Refactor skill tool to reuse unified getAllSkills()
- Add async skill resolution tests
2026-01-16 01:57:57 +09:00
justsisyphus
5de3d4fb7d fix(ci): add NPM_TOKEN support for npm publishing
npm revoked all classic tokens. Workflow now requires NPM_TOKEN secret
with granular access token for publishing.
2026-01-16 01:23:00 +09:00
justsisyphus
7a9e604b2d fix(ci): revert publish runner to ubuntu-latest for npm OIDC
macOS runner breaks npm OIDC trusted publishing. Bun can cross-compile
all platform binaries on ubuntu, so macOS runner is not needed.
2026-01-16 01:17:22 +09:00
justsisyphus
6670754efe fix(ci): add registry-url to setup-node for npm OIDC auth
setup-node requires registry-url to configure .npmrc for OIDC authentication
2026-01-16 01:10:37 +09:00
justsisyphus
37d4aec4d0 fix(ci): use bunx tsc instead of bare tsc in publish workflow
tsc is not in PATH when installed via bun - use bunx to run from node_modules/.bin
2026-01-16 00:55:12 +09:00
Jeon Suyeol
c38b078c12 fix(test): isolate environment in non-interactive-env hook tests (#822)
- Delete PSModulePath in beforeEach() to prevent CI cross-platform detection
- Set SHELL=/bin/bash to ensure tests start with clean Unix-like environment
- Fixes flaky test failures on GitHub Actions CI runners
- Tests can still override these values for PowerShell-specific behavior
2026-01-16 00:54:53 +09:00
Kenny
5e44996746 Merge pull request #813 from KNN-07/fix/start-work-ultrawork-plan-confusion
fix(start-work): honor explicit plan name and strip ultrawork keywords
2026-01-15 10:42:45 -05:00
sisyphus-dev-ai
9a152bcebb chore: changes by sisyphus-dev-ai 2026-01-15 15:34:12 +00:00
Kenny
c67ca8275e feat: Bun single-file executable distribution (#819)
* feat: add Bun single-file executable distribution

- Add 7 platform packages for standalone CLI binaries
- Add bin/platform.js for shared platform detection
- Add bin/oh-my-opencode.js ESM wrapper
- Add postinstall.mjs for binary verification
- Add script/build-binaries.ts for cross-compilation
- Update publish workflow for multi-package publishing
- Add CI guard against @ast-grep/napi in CLI
- Add unit tests for platform detection (12 tests)
- Update README to remove Bun runtime requirement

Platforms supported:
- macOS ARM64 & x64
- Linux x64 & ARM64 (glibc)
- Linux x64 & ARM64 (musl/Alpine)
- Windows x64

Closes #816

* chore: remove unnecessary @ast-grep/napi CI check

* chore: gitignore compiled platform binaries

* fix: use require() instead of top-level await import() for Bun compile compatibility

* refactor: use static ESM import for package.json instead of require()
2026-01-16 00:33:07 +09:00
justsisyphus
72a3975799 fix(ci): add missing --copilot=no flag to agent workflow 2026-01-16 00:26:44 +09:00
Kenny
747d824cbf Merge pull request #818 from code-yeongyu/fix/sisyphus-orchestrator-test-assertions
fix(sisyphus-orchestrator): update test assertions to match new prompt text
2026-01-15 08:44:52 -05:00
Kenny
b8a8cc95e2 fix(sisyphus-orchestrator): update test assertions to match new prompt text
Update 5 test assertions to use stable substrings following section-markers
best practice:
- "MANDATORY VERIFICATION" → "MANDATORY:" (2 places)
- "SUBAGENTS LIE" → "LIE" (1 place)
- "0 left" → "0 remaining" (1 place)
- "2 left" → "2 remaining" (1 place)

Fixes test failures introduced in 9bed597.
2026-01-15 08:40:28 -05:00