Commit Graph

1212 Commits

Author SHA1 Message Date
justsisyphus
b4fa31a47a fix(test): add _resetForTesting for proper test isolation 2026-01-17 16:57:31 +09:00
justsisyphus
ec2cf22449 fix(ci): enable platform binaries publishing 2026-01-17 16:48:44 +09:00
justsisyphus
f6d4201d7d fix(test): add nested beforeEach for mainSessionID test isolation
Previous test was setting mainSessionID to 'main-session-123' and the
next test expected undefined. The outer beforeEach wasn't properly
resetting state between tests in the nested describe block.

Adding a nested beforeEach ensures proper test isolation.
2026-01-17 16:47:56 +09:00
Kenny
5cb5dbef42 Merge pull request #863 from sgwannabe/fix/keyword-detector-skip-background-tasks
fix(keyword-detector): skip keyword detection for background task sessions
2026-01-16 21:30:44 -05:00
github-actions[bot]
7d796738a2 @sgwannabe has signed the CLA in code-yeongyu/oh-my-opencode#863 2026-01-17 01:26:09 +00:00
Sangguen Chang
0823dbe4d4 fix(keyword-detector): skip keyword detection for background task sessions
Skip all keyword detection for background task sessions to prevent mode
injection (e.g., [analyze-mode], [search-mode]) which incorrectly triggers
Prometheus planner restrictions on Sisyphus sessions.

This aligns with the existing pattern used in:
- sisyphus-orchestrator (line 504)
- todo-continuation-enforcer (line 303)
- session-notification (line 278)

Closes #713
2026-01-17 10:23:23 +09:00
Kenny
8391b8a7a5 Merge pull request #855 from luojiyin1987/fix/doctor-windows-opencode
fix: handle opencode.ps1 in doctor on Windows
2026-01-16 15:36:58 -05:00
Kenny
903a1534a4 Merge pull request #859 from qwertystars/fix/migration-import-path
fix(migration): correct import path for DEFAULT_CATEGORIES
2026-01-16 15:36:15 -05:00
Srijan Guchhait
bbaf78ac70 Merge branch 'code-yeongyu:dev' into fix/migration-import-path 2026-01-17 00:27:31 +05:30
github-actions[bot]
79dab37569 @qwertystars has signed the CLA in code-yeongyu/oh-my-opencode#859 2026-01-16 18:14:03 +00:00
qwertystars
374083fa0e fix(migration): correct import path for DEFAULT_CATEGORIES
The import was pointing to non-existent sisyphus-task/constants,
updated to delegate-task/constants where DEFAULT_CATEGORIES is defined.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-16 23:42:41 +05:30
github-actions[bot]
0b9cf32190 @luojiyin1987 has signed the CLA in code-yeongyu/oh-my-opencode#855 2026-01-16 15:54:19 +00:00
github-actions[bot]
a5097a4efe @vmlinuzx has signed the CLA in code-yeongyu/oh-my-opencode#837 2026-01-16 15:49:51 +00:00
luojiyin
15b91f50f6 fix: handle opencode.ps1 in doctor on Windows
Handle Windows where lookup and prefer exe/cmd/bat; fall back to ps1 and run via PowerShell for version detection.

Tests: bun test src/cli/doctor/checks/opencode.test.ts
2026-01-16 23:42:08 +08:00
Kenny
30f3dd2646 Merge pull request #834 from MotorwaySouth9/fix/windows-lsp-doctor-and-detection
fix(lsp): improve Windows server detection and avoid unix 'which' in doctor
2026-01-16 07:24:05 -05:00
Kenny
cf7b23be5e Merge pull request #847 from minkichoe-lbox/fix/dynamic-year
fix(librarian): use dynamic year instead of hardcoded 2024/2025
2026-01-16 07:14:58 -05:00
justsisyphus
0c000596dc fix(sisyphus-orchestrator): add debounce to boulder continuation to prevent infinite loop
Add 5-second cooldown between continuation injections to prevent rapid-fire
session.idle events from causing infinite loop when boulder has incomplete tasks.
2026-01-16 19:17:26 +09:00
justsisyphus
5ee8996a39 fix(keyword-detector): use session state for agent-specific ultrawork templates
Bug: When switching from Prometheus to Sisyphus, the Prometheus ultrawork
template was still injected because:
1. setSessionAgent() only sets on first call, ignoring subsequent updates
2. keyword-detector relied solely on input.agent which could be stale

Fix:
- Use updateSessionAgent() instead of setSessionAgent() in index.ts
- keyword-detector now uses getSessionAgent() as primary source, fallback to input.agent
- Added tests for agent switch scenario
2026-01-16 19:06:00 +09:00
justsisyphus
7cd59e9c0a feat(toast): show warning only for fallback models (inherited/system-default)
category-default is the intended behavior for builtin categories,
not a fallback. Only show toast warning when:
- inherited: model from parent session (custom category without model)
- system-default: OpenCode's global default model

User-defined and category-default are both expected behaviors,
so no warning is needed.
2026-01-16 18:47:36 +09:00
justsisyphus
cb6f1c9f75 fix(delegate-task): category default model takes precedence over parent model
Previously, parent model string would override category default model,
causing categories like 'ultrabrain' to use the parent's model (e.g., sonnet)
instead of the intended category default (e.g., gpt-5.2).

Model priority is now:
1. userConfig.model (oh-my-opencode.json override)
2. defaultConfig.model (category default)
3. parentModelString (fallback)
4. systemDefaultModel (last resort)
2026-01-16 18:45:19 +09:00
justsisyphus
eeb7eb2be2 refactor(agent-tool-restrictions): use boolean for SDK tools parameter
OpenCode SDK's session.prompt tools parameter expects boolean values.
Changed from PermissionValue ('deny'/'allow') to boolean (false/true).
2026-01-16 18:31:08 +09:00
justsisyphus
fd6a33b88f fix(context-injector): add mainSessionID fallback for synthetic part injection
The transform hook was failing to inject synthetic parts because
message.info.sessionID is not always available in the OpenCode SDK.

Fix: Use getMainSessionID() as fallback when message.info.sessionID is undefined.

This ensures keyword-detector and claude-code-hooks content (like ulw/ultrawork)
is properly injected even when the SDK doesn't provide sessionID in message.info.
2026-01-16 18:31:08 +09:00
justsisyphus
e22960d862 test(context-injector): update tests for synthetic part injection
- Remove injectPendingContext test block (~118 lines)
- Remove createContextInjectorHook test block (~50 lines)
- Remove imports of removed functions
- Remove exports of removed functions from index.ts
- Keep createContextInjectorMessagesTransformHook tests (updated in Task 2)
2026-01-16 18:31:08 +09:00
justsisyphus
ea1d604b72 chore(index): remove contextInjector chat.message hook call
- Remove createContextInjectorHook from imports
- Remove contextInjector variable declaration
- Remove contextInjector["chat.message"] call
- Keep contextInjectorMessagesTransform for synthetic part injection
- Update test: prepend → synthetic part insertion verification
2026-01-16 18:31:08 +09:00
justsisyphus
d3e3371a77 refactor(context-injector): remove chat.message hook, insert synthetic part in transform
- Remove injectPendingContext function (no longer needed)
- Remove createContextInjectorHook function (chat.message hook removed)
- Change transform hook from prepend to synthetic part insertion
- Follow empty-message-sanitizer pattern (minimal field set)
- synthetic: true flag hides content from UI but passes to model
- Synthetic part inserted BEFORE user text part
2026-01-16 18:31:08 +09:00
justsisyphus
188bbef018 refactor: rename sisyphus_task to delegate_task
- Rename directories: sisyphus-task → delegate-task
- Rename types: SisyphusTaskArgs → DelegateTaskArgs, etc.
- Rename functions: createSisyphusTask → createDelegateTask
- Rename constants: SISYPHUS_TASK_* → DELEGATE_TASK_*
- Update tool name: sisyphus_task → delegate_task
- Update all prompts, docs, and tests
2026-01-16 18:31:08 +09:00
justsisyphus
6008388a4e feat(prometheus): auto-generate plan workflow with self-review
- Remove intermediate questions before plan generation
- Auto-proceed with Metis consultation
- Generate plan immediately after Metis review
- Add Post-Plan Self-Review with gap classification:
  - CRITICAL: requires user input
  - MINOR: auto-resolve silently
  - AMBIGUOUS: apply default and disclose
- Present summary with auto-resolved items and decisions needed
- Ask high accuracy question after summary
2026-01-16 18:31:08 +09:00
github-actions[bot]
880e29e883 @minkichoe-lbox has signed the CLA in code-yeongyu/oh-my-opencode#847 2026-01-16 09:14:31 +00:00
minkichoe
47e64a4a92 fix(librarian): use dynamic year instead of hardcoded 2024/2025 2026-01-16 18:14:00 +09:00
justsisyphus
e23ce11df9 feat: allow Sisyphus-Junior to call sisyphus_task 2026-01-16 17:14:31 +09:00
justsisyphus
f1cdb3bce1 feat: global sisyphus_task deny with orchestrator exceptions
- Add sisyphus_task: deny to global config.permission
- Add sisyphus_task: allow exception for orchestrator-sisyphus, Sisyphus, and Prometheus (Planner)
- Ensures only orchestrator agents can spawn sisyphus_task subagents
2026-01-16 17:13:08 +09:00
justsisyphus
83cbc56709 refactor: remove legacy tools format, use permission only
BREAKING: Requires OpenCode 1.1.1+

- Remove supportsNewPermissionSystem/usesLegacyToolsSystem checks
- Simplify permission-compat.ts to permission format only
- Unify explore/librarian deny lists: write, edit, task, sisyphus_task, call_omo_agent
- Add sisyphus_task to oracle deny list
- Update agent-tool-restrictions.ts with correct per-agent restrictions
- Clean config-handler.ts conditional version checks
- Update tests for simplified API
2026-01-16 17:11:34 +09:00
justsisyphus
ede9abceb3 feat(multimodal-looker): restrict to read-only tool access
Use createAgentToolAllowlist to allow only 'read' tool for multimodal-looker agent.
Previously denied write/edit/bash but allowed other tools.
Now uses wildcard deny pattern (*: deny) with explicit read allow.

- Add createAgentToolAllowlist function for allowlist-based restrictions
- Support legacy fallback for older OpenCode versions
- Add 4 test cases covering both permission systems
2026-01-16 15:02:55 +09:00
justsisyphus
27ef9fa8df feat(orchestrator): emphasize project-level lsp_diagnostics and QA verification
- Add mandatory PROJECT-LEVEL code checks (lsp_diagnostics at src/ or . level)
- Strengthen verification duties with explicit QA checklist
- Add 'SUBAGENTS LIE - VERIFY EVERYTHING' reminders throughout
- Emphasize that only orchestrator sees full picture of cross-file impacts
2026-01-16 14:11:56 +09:00
justsisyphus
333db56172 refactor(agents): remove lsp_diagnostics from Sisyphus and Sisyphus-Junior prompts
Orchestrator Sisyphus will handle project-level code validation instead of
having each subagent run file-level lsp_diagnostics.
2026-01-16 14:09:28 +09:00
justsisyphus
1ecb2bafdf fix(hooks): prevent start-work false trigger from command description
- Remove 'Start Sisyphus work session' text check, keep only <session-context> tag
- Update interactive_bash description with WARNING: TMUX ONLY emphasis
- Update tests to use <session-context> wrapper
2026-01-16 14:01:29 +09:00
justsisyphus
d00c2e7439 fix(hooks): extract model from assistant messages with flat modelID/providerID
OpenCode API returns different structures for user vs assistant messages:
- User: info.model = { providerID, modelID } (nested)
- Assistant: info.modelID, info.providerID (flat top-level)

Previous code only checked nested format, causing model info loss when
continuation hooks fired after assistant messages.

Files modified:
- todo-continuation-enforcer.ts
- ralph-loop/index.ts
- sisyphus-task/tools.ts
- background-agent/manager.ts

Added test for assistant message model extraction.
2026-01-16 13:54:22 +09:00
justsisyphus
8d545723dc refactor(orchestrator): restructure post-verification workflow as Step 4-6
- Unified verification (Step 1-3) and post-verification (Step 4-6) into continuous workflow
- Step 4: Immediate plan file marking after verification passes
- Step 5: Commit atomic unit
- Step 6: Proceed to next task
- Emphasized immediacy: 'RIGHT NOW - Do not delay'
- Applied to both boulder state and standalone reminder contexts
2026-01-16 13:48:18 +09:00
justsisyphus
e737477fbe feat(prometheus): strengthen plan-mode constraints with constraint-first architecture
- Move Turn Termination Rules inside <system-reminder> block (from line 488 to ~186)
- Add Final Constraint Reminder at end of prompt (constraint sandwich pattern)
- Preserve all existing interview mode detail and strategies

Applies OpenCode's effective constraint patterns to prevent plan-mode agents
from offering to implement work instead of staying in consultation mode.
2026-01-16 13:36:46 +09:00
justsisyphus
aa859f8cdd feat(sisyphus-task): require explicit skills parameter - reject empty array []
- Change skills type from string[] to string[] | null
- Empty array [] now returns error with available skills list
- null is allowed for tasks that genuinely need no skills
- Updated tests to use skills: null instead of skills: []
- Forces explicit decision: either specify skills or justify with null
2026-01-16 13:12:48 +09:00
justsisyphus
c282244439 fix: store session agent in chat.message for prometheus-md-only hook
The prometheus-md-only hook was not enforcing file restrictions because
getSessionAgent() returned undefined - setSessionAgent was only called
in message.updated event which doesn't always provide agent info.

- Add setSessionAgent call in chat.message hook when input.agent exists
- Add session state tests for setSessionAgent/getSessionAgent
- Add clearSessionAgent cleanup to prometheus-md-only tests

This ensures prometheus-md-only hook can reliably identify Prometheus
sessions and enforce .sisyphus/*.md write restrictions.
2026-01-16 11:35:37 +09:00
justsisyphus
75925d5433 fix: clear session agent on /start-work to allow mode transition from Prometheus
When transitioning from Prometheus (Planner) to Sisyphus via /start-work,
the session agent was not being cleared. This caused prometheus-md-only
hook to continue injecting READ-ONLY constraints into sisyphus_task calls.

- Add clearSessionAgent() call when start-work command is detected
- Add TDD test verifying clearSessionAgent is called with sessionID
2026-01-16 11:35:37 +09:00
justsisyphus
c7ca608b38 refactor: unify system directive prefix for keyword-detector filtering
- Add shared/system-directive.ts with SYSTEM_DIRECTIVE_PREFIX constant
- Unify all system message prefixes to [SYSTEM DIRECTIVE: OH-MY-OPENCODE - ...]
- Add isSystemDirective() filter to keyword-detector to skip system messages
- Update prometheus-md-only tests to use new prefix constants
2026-01-16 11:35:37 +09:00
justsisyphus
b933992e36 refactor: remove dcp_for_compaction and preemptive_compaction features
- Delete src/hooks/preemptive-compaction/ entirely
- Remove dcp_for_compaction from schema and executor
- Clean up related imports, options, and test code
- Update READMEs to remove experimental options docs
2026-01-16 11:35:37 +09:00
justsisyphus
bf28b3e711 fix: ensure Sisyphus agent has call_omo_agent disabled
The tools restriction was defined in sisyphus.ts but not enforced in
config-handler.ts like other agents (orchestrator-sisyphus, Prometheus).
Added explicit tools setting to guarantee call_omo_agent is disabled.
2026-01-16 11:35:37 +09:00
justsisyphus
9363324e0e refactor(lsp): clean up lsp_servers references and update prompts to use PascalCase
- Remove dead lsp_servers function from tools.ts
- Update utils.ts to reference LspServers (OpenCode built-in)
- Update AGENTS.md: 7 tools → 3 tools
- Update init-deep.ts prompts to use PascalCase OpenCode tools
- Update refactor.ts prompts to use PascalCase OpenCode tools
2026-01-16 11:35:37 +09:00
MotorwaySouth9
8e02cab307 test: stub gh cli spawn and refine PATH cleanup 2026-01-16 10:31:53 +08:00
Kenny
f888da8848 Merge pull request #833 from KNN-07/fix/git-master-watermark-injection
fix(git-master): inject watermark only when enabled instead of overriding defaults
2026-01-15 20:36:18 -05:00
justsisyphus
9fb284d4b5 docs: update LSP tools list in all READMEs
Remove OpenCode built-in tools (lsp_goto_definition, lsp_find_references, lsp_symbols, lsp_servers) that are not provided by oh-my-opencode. Keep only lsp_diagnostics, lsp_prepare_rename, lsp_rename.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:33:55 +09:00
justsisyphus
584aecf266 refactor(config): disable unused OpenCode built-in LSP tools
LspHover, LspCodeActions, LspCodeActionResolve are disabled globally as they are not needed when using oh-my-opencode's curated LSP tools.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:33:44 +09:00