bc782ca4d4
Fixes #1521. When hook matcher patterns contained regex special characters like parentheses, the pattern-matcher would throw 'SyntaxError: Invalid regular expression: unmatched parentheses' because these characters were not escaped before constructing the RegExp. The fix escapes all regex special characters (.+?^${}()|[\]\) EXCEPT the asterisk (*) which is intentionally converted to .* for glob-style matching. Add comprehensive test suite for pattern-matcher covering: - Exact matching (case-insensitive) - Wildcard matching (glob-style *) - Pipe-separated patterns - All regex special characters (parentheses, brackets, etc.) - Edge cases (empty matcher, complex patterns)
41 lines
1.3 KiB
TypeScript
41 lines
1.3 KiB
TypeScript
import type { ClaudeHooksConfig, HookMatcher } from "../hooks/claude-code-hooks/types"
|
|
|
|
/**
|
|
* Escape all regex special characters EXCEPT asterisk (*).
|
|
* Asterisk is preserved for glob-to-regex conversion.
|
|
*/
|
|
function escapeRegexExceptAsterisk(str: string): string {
|
|
// Escape all regex special chars except * (which we convert to .* for glob matching)
|
|
return str.replace(/[.+?^${}()|[\]\\]/g, "\\$&")
|
|
}
|
|
|
|
export function matchesToolMatcher(toolName: string, matcher: string): boolean {
|
|
if (!matcher) {
|
|
return true
|
|
}
|
|
const patterns = matcher.split("|").map((p) => p.trim())
|
|
return patterns.some((p) => {
|
|
if (p.includes("*")) {
|
|
// First escape regex special chars (except *), then convert * to .*
|
|
const escaped = escapeRegexExceptAsterisk(p)
|
|
const regex = new RegExp(`^${escaped.replace(/\*/g, ".*")}$`, "i")
|
|
return regex.test(toolName)
|
|
}
|
|
return p.toLowerCase() === toolName.toLowerCase()
|
|
})
|
|
}
|
|
|
|
export function findMatchingHooks(
|
|
config: ClaudeHooksConfig,
|
|
eventName: keyof ClaudeHooksConfig,
|
|
toolName?: string
|
|
): HookMatcher[] {
|
|
const hookMatchers = config[eventName]
|
|
if (!hookMatchers) return []
|
|
|
|
return hookMatchers.filter((hookMatcher) => {
|
|
if (!toolName) return true
|
|
return matchesToolMatcher(toolName, hookMatcher.matcher)
|
|
})
|
|
}
|