sapient/oh-my-openagent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(restack): drop stale compatibility expectations

Browse Source
This commit is contained in:
Ravi Tharuma
2026-03-25 10:08:00 +01:00
parent f86b8b3336
commit 9d930656da
1 changed files with 0 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

92
src/shared/model-settings-compatibility.test.ts
View File

@@ -90,29 +90,6 @@ describe("resolveCompatibleModelSettings", () => {
})
})
test("downgrades gpt-5 reasoningEffort max to xhigh", () => {
// given
const input = {
providerID: "openai",
modelID: "gpt-5.4",
desired: { reasoningEffort: "max" },
}
// when
const result = resolveCompatibleModelSettings(input)
// then
expect(result.reasoningEffort).toBe("xhigh")
expect(result.changes).toEqual([
{
field: "reasoningEffort",
from: "max",
to: "xhigh",
reason: "unsupported-by-model-family",
},
])
})
test("keeps supported OpenAI reasoning-family effort for o-series models", () => {
const result = resolveCompatibleModelSettings({
providerID: "openai",
@@ -127,75 +104,6 @@ describe("resolveCompatibleModelSettings", () => {
})
})
test("downgrades openai reasoning-family effort xhigh to high", () => {
// given
const input = {
providerID: "openai",
modelID: "o3-mini",
desired: { reasoningEffort: "xhigh" },
}
// when
const result = resolveCompatibleModelSettings(input)
// then
expect(result.reasoningEffort).toBe("high")
expect(result.changes).toEqual([
{
field: "reasoningEffort",
from: "xhigh",
to: "high",
reason: "unsupported-by-model-family",
},
])
})
test("drops reasoningEffort for gpt-5 mini models", () => {
// given
const input = {
providerID: "openai",
modelID: "gpt-5.4-mini",
desired: { reasoningEffort: "high" },
}
// when
const result = resolveCompatibleModelSettings(input)
// then
expect(result.reasoningEffort).toBeUndefined()
expect(result.changes).toEqual([
{
field: "reasoningEffort",
from: "high",
to: undefined,
reason: "unsupported-by-model-family",
},
])
})
test("treats non-openai o-series models as unknown", () => {
// given
const input = {
providerID: "ollama",
modelID: "o3",
desired: { reasoningEffort: "high" },
}
// when
const result = resolveCompatibleModelSettings(input)
// then
expect(result.reasoningEffort).toBeUndefined()
expect(result.changes).toEqual([
{
field: "reasoningEffort",
from: "high",
to: undefined,
reason: "unknown-model-family",
},
])
})
test("does not record case-only normalization as a compatibility downgrade", () => {
const result = resolveCompatibleModelSettings({
providerID: "openai",