sapient/oh-my-openagent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tests): stabilize toast manager and continuation tests

Browse Source
This commit is contained in:
YeonGyu-Kim
2026-02-10 17:19:06 +09:00
parent 2bf11a8ed7
commit 7fe1a653c8
5 changed files with 100 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/features/task-toast-manager/manager.test.ts
View File

@@ -1,17 +1,20 @@
import { describe, test, expect, beforeEach, mock } from "bun:test"
import { TaskToastManager } from "./manager"
declare const require: (name: string) => any
const { describe, test, expect, beforeEach, afterEach, mock } = require("bun:test")
import type { ConcurrencyManager } from "../background-agent/concurrency"
type TaskToastManagerClass = typeof import("./manager").TaskToastManager
describe("TaskToastManager", () => {
let TaskToastManager: TaskToastManagerClass
let mockClient: {
tui: {
showToast: ReturnType<typeof mock>
}
}
let toastManager: TaskToastManager
let toastManager: InstanceType<TaskToastManagerClass>
let mockConcurrencyManager: ConcurrencyManager
beforeEach(() => {
beforeEach(async () => {
mockClient = {
tui: {
showToast: mock(() => Promise.resolve()),
@@ -20,10 +23,18 @@ describe("TaskToastManager", () => {
mockConcurrencyManager = {
getConcurrencyLimit: mock(() => 5),
} as unknown as ConcurrencyManager
const mod = await import("./manager")
TaskToastManager = mod.TaskToastManager
// eslint-disable-next-line @typescript-eslint/no-explicit-any
toastManager = new TaskToastManager(mockClient as any, mockConcurrencyManager)
})
afterEach(() => {
mock.restore()
})
describe("skills in toast message", () => {
test("should display skills when provided", () => {
// given - a task with skills

4
src/features/task-toast-manager/manager.ts
View File

@@ -217,3 +217,7 @@ export function initTaskToastManager(
instance = new TaskToastManager(client, concurrencyManager)
return instance
}
export function _resetTaskToastManagerForTesting(): void {
instance = null
}

18
src/tools/delegate-task/category-resolver.test.ts
View File

@@ -1,8 +1,24 @@
import { describe, test, expect } from "bun:test"
declare const require: (name: string) => any
const { describe, test, expect, beforeEach, afterEach, spyOn, mock } = require("bun:test")
import { resolveCategoryExecution } from "./category-resolver"
import type { ExecutorContext } from "./executor-types"
import * as connectedProvidersCache from "../../shared/connected-providers-cache"
describe("resolveCategoryExecution", () => {
let connectedProvidersSpy: ReturnType<typeof spyOn> | undefined
let providerModelsSpy: ReturnType<typeof spyOn> | undefined
beforeEach(() => {
mock.restore()
connectedProvidersSpy = spyOn(connectedProvidersCache, "readConnectedProvidersCache").mockReturnValue(null)
providerModelsSpy = spyOn(connectedProvidersCache, "readProviderModelsCache").mockReturnValue(null)
})
afterEach(() => {
connectedProvidersSpy?.mockRestore()
providerModelsSpy?.mockRestore()
})
const createMockExecutorContext = (): ExecutorContext => ({
client: {} as any,
manager: {} as any,

43
src/tools/delegate-task/sync-continuation.test.ts
View File

@@ -1,9 +1,9 @@
declare const require: (name: string) => any
const { describe, test, expect, beforeEach, afterEach, mock } = require("bun:test")
const { describe, test, expect, beforeEach, afterEach, mock, spyOn } = require("bun:test")
describe("executeSyncContinuation - toast cleanup error paths", () => {
let removeTaskCalls: string[] = []
let addTaskCalls: any[] = []
let resetToastManager: (() => void) | null = null
beforeEach(() => {
//#given - configure fast timing for all tests
@@ -19,19 +19,21 @@ describe("executeSyncContinuation - toast cleanup error paths", () => {
removeTaskCalls = []
addTaskCalls = []
//#given - mock task-toast-manager module
const mockToastManager = {
addTask: (task: any) => { addTaskCalls.push(task) },
removeTask: (id: string) => { removeTaskCalls.push(id) },
}
//#given - initialize real task toast manager (avoid global module mocks)
const { initTaskToastManager, _resetTaskToastManagerForTesting } = require("../../features/task-toast-manager/manager")
_resetTaskToastManagerForTesting()
resetToastManager = _resetTaskToastManagerForTesting
const mockGetTaskToastManager = () => mockToastManager
const toastManager = initTaskToastManager({
tui: { showToast: mock(() => Promise.resolve()) },
})
mock.module("../../features/task-toast-manager/index.ts", () => ({
getTaskToastManager: mockGetTaskToastManager,
TaskToastManager: class {},
initTaskToastManager: () => mockToastManager,
}))
spyOn(toastManager, "addTask").mockImplementation((task: any) => {
addTaskCalls.push(task)
})
spyOn(toastManager, "removeTask").mockImplementation((id: string) => {
removeTaskCalls.push(id)
})
//#given - mock other dependencies
mock.module("./sync-session-poller.ts", () => ({
@@ -48,7 +50,9 @@ describe("executeSyncContinuation - toast cleanup error paths", () => {
const { __resetTimingConfig } = require("./timing")
__resetTimingConfig()
mock.restore()
mock.restore()
resetToastManager?.()
resetToastManager = null
})
test("removes toast when fetchSyncResult throws", async () => {
@@ -294,14 +298,9 @@ describe("executeSyncContinuation - toast cleanup error paths", () => {
})
test("no crash when toastManager is null", async () => {
//#given - mock task-toast-manager module to return null
const mockGetTaskToastManager = () => null
mock.module("../../features/task-toast-manager/index.ts", () => ({
getTaskToastManager: mockGetTaskToastManager,
TaskToastManager: class {},
initTaskToastManager: () => null,
}))
//#given - reset toast manager instance to null
const { _resetTaskToastManagerForTesting } = require("../../features/task-toast-manager/manager")
_resetTaskToastManagerForTesting()
const mockClient = {
session: {

63
src/tools/delegate-task/tools.test.ts
View File

@@ -1132,27 +1132,50 @@ describe("sisyphus-task", () => {
launch: async () => mockTask,
}
let messagesCallCount = 0
const mockClient = {
session: {
prompt: async () => ({ data: {} }),
promptAsync: async () => ({ data: {} }),
messages: async () => ({
data: [
{
info: { id: "msg_001", role: "user", time: { created: Date.now() } },
parts: [{ type: "text", text: "Continue the task" }],
},
{
info: { id: "msg_002", role: "assistant", time: { created: Date.now() + 1 }, finish: "end_turn" },
parts: [{ type: "text", text: "This is the continued task result" }],
},
],
}),
status: async () => ({ data: { "ses_continue_test": { type: "idle" } } }),
},
config: { get: async () => ({ data: { model: SYSTEM_DEFAULT_MODEL } }) },
app: {
agents: async () => ({ data: [] }),
session: {
prompt: async () => ({ data: {} }),
promptAsync: async () => ({ data: {} }),
messages: async () => {
messagesCallCount++
const now = Date.now()
const beforeContinuation = [
{
info: { id: "msg_001", role: "user", time: { created: now } },
parts: [{ type: "text", text: "Previous context" }],
},
{
info: { id: "msg_002", role: "assistant", time: { created: now + 1 }, finish: "end_turn" },
parts: [{ type: "text", text: "Previous result" }],
},
]
if (messagesCallCount === 1) {
return { data: beforeContinuation }
}
return {
data: [
...beforeContinuation,
{
info: { id: "msg_003", role: "user", time: { created: now + 2 } },
parts: [{ type: "text", text: "Continue the task" }],
},
{
info: { id: "msg_004", role: "assistant", time: { created: now + 3 }, finish: "end_turn" },
parts: [{ type: "text", text: "This is the continued task result" }],
},
],
}
},
status: async () => ({ data: { "ses_continue_test": { type: "idle" } } }),
},
config: { get: async () => ({ data: { model: SYSTEM_DEFAULT_MODEL } }) },
app: {
agents: async () => ({ data: [] }),
},
}