299 lines
8.5 KiB
TypeScript
299 lines
8.5 KiB
TypeScript
import { describe, expect, test, beforeEach, afterEach, mock } from "bun:test"
|
|
import { mkdirSync, rmSync, writeFileSync } from "node:fs"
|
|
import { join } from "node:path"
|
|
import { createPrometheusMdOnlyHook } from "./index"
|
|
import { MESSAGE_STORAGE } from "../../features/hook-message-injector"
|
|
|
|
describe("prometheus-md-only", () => {
|
|
const TEST_SESSION_ID = "test-session-prometheus"
|
|
let testMessageDir: string
|
|
|
|
function createMockPluginInput() {
|
|
return {
|
|
client: {},
|
|
directory: "/tmp/test",
|
|
} as never
|
|
}
|
|
|
|
function setupMessageStorage(sessionID: string, agent: string): void {
|
|
testMessageDir = join(MESSAGE_STORAGE, sessionID)
|
|
mkdirSync(testMessageDir, { recursive: true })
|
|
const messageContent = {
|
|
agent,
|
|
model: { providerID: "test", modelID: "test-model" },
|
|
}
|
|
writeFileSync(
|
|
join(testMessageDir, "msg_001.json"),
|
|
JSON.stringify(messageContent)
|
|
)
|
|
}
|
|
|
|
afterEach(() => {
|
|
if (testMessageDir) {
|
|
try {
|
|
rmSync(testMessageDir, { recursive: true, force: true })
|
|
} catch {
|
|
// ignore
|
|
}
|
|
}
|
|
})
|
|
|
|
describe("with Prometheus agent in message storage", () => {
|
|
beforeEach(() => {
|
|
setupMessageStorage(TEST_SESSION_ID, "Prometheus (Planner)")
|
|
})
|
|
|
|
test("should block Prometheus from writing non-.md files", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "Write",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { filePath: "/path/to/file.ts" },
|
|
}
|
|
|
|
// #when / #then
|
|
await expect(
|
|
hook["tool.execute.before"](input, output)
|
|
).rejects.toThrow("can only write/edit .md files")
|
|
})
|
|
|
|
test("should allow Prometheus to write .md files inside .sisyphus/", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "Write",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { filePath: "/project/.sisyphus/plans/work-plan.md" },
|
|
}
|
|
|
|
// #when / #then
|
|
await expect(
|
|
hook["tool.execute.before"](input, output)
|
|
).resolves.toBeUndefined()
|
|
})
|
|
|
|
test("should block Prometheus from writing .md files outside .sisyphus/", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "Write",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { filePath: "/path/to/README.md" },
|
|
}
|
|
|
|
// #when / #then
|
|
await expect(
|
|
hook["tool.execute.before"](input, output)
|
|
).rejects.toThrow("can only write/edit .md files inside .sisyphus/")
|
|
})
|
|
|
|
test("should block Edit tool for non-.md files", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "Edit",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { filePath: "/path/to/code.py" },
|
|
}
|
|
|
|
// #when / #then
|
|
await expect(
|
|
hook["tool.execute.before"](input, output)
|
|
).rejects.toThrow("can only write/edit .md files")
|
|
})
|
|
|
|
test("should not affect non-Write/Edit tools", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "Read",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { filePath: "/path/to/file.ts" },
|
|
}
|
|
|
|
// #when / #then
|
|
await expect(
|
|
hook["tool.execute.before"](input, output)
|
|
).resolves.toBeUndefined()
|
|
})
|
|
|
|
test("should handle missing filePath gracefully", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "Write",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: {},
|
|
}
|
|
|
|
// #when / #then
|
|
await expect(
|
|
hook["tool.execute.before"](input, output)
|
|
).resolves.toBeUndefined()
|
|
})
|
|
|
|
test("should inject read-only warning when Prometheus calls sisyphus_task", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "sisyphus_task",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { prompt: "Analyze this codebase" },
|
|
}
|
|
|
|
// #when
|
|
await hook["tool.execute.before"](input, output)
|
|
|
|
// #then
|
|
expect(output.args.prompt).toContain("[SYSTEM DIRECTIVE - READ-ONLY PLANNING CONSULTATION]")
|
|
expect(output.args.prompt).toContain("DO NOT modify any files")
|
|
})
|
|
|
|
test("should inject read-only warning when Prometheus calls task", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "task",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { prompt: "Research this library" },
|
|
}
|
|
|
|
// #when
|
|
await hook["tool.execute.before"](input, output)
|
|
|
|
// #then
|
|
expect(output.args.prompt).toContain("[SYSTEM DIRECTIVE - READ-ONLY PLANNING CONSULTATION]")
|
|
})
|
|
|
|
test("should inject read-only warning when Prometheus calls call_omo_agent", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "call_omo_agent",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { prompt: "Find implementation examples" },
|
|
}
|
|
|
|
// #when
|
|
await hook["tool.execute.before"](input, output)
|
|
|
|
// #then
|
|
expect(output.args.prompt).toContain("[SYSTEM DIRECTIVE - READ-ONLY PLANNING CONSULTATION]")
|
|
})
|
|
|
|
test("should not double-inject warning if already present", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "sisyphus_task",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const promptWithWarning = "Some prompt [SYSTEM DIRECTIVE - READ-ONLY PLANNING CONSULTATION] already here"
|
|
const output = {
|
|
args: { prompt: promptWithWarning },
|
|
}
|
|
|
|
// #when
|
|
await hook["tool.execute.before"](input, output)
|
|
|
|
// #then
|
|
const occurrences = (output.args.prompt as string).split("[SYSTEM DIRECTIVE - READ-ONLY PLANNING CONSULTATION]").length - 1
|
|
expect(occurrences).toBe(1)
|
|
})
|
|
})
|
|
|
|
describe("with non-Prometheus agent in message storage", () => {
|
|
beforeEach(() => {
|
|
setupMessageStorage(TEST_SESSION_ID, "Sisyphus")
|
|
})
|
|
|
|
test("should not affect non-Prometheus agents", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "Write",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { filePath: "/path/to/file.ts" },
|
|
}
|
|
|
|
// #when / #then
|
|
await expect(
|
|
hook["tool.execute.before"](input, output)
|
|
).resolves.toBeUndefined()
|
|
})
|
|
|
|
test("should not inject warning for non-Prometheus agents calling sisyphus_task", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "sisyphus_task",
|
|
sessionID: TEST_SESSION_ID,
|
|
callID: "call-1",
|
|
}
|
|
const originalPrompt = "Implement this feature"
|
|
const output = {
|
|
args: { prompt: originalPrompt },
|
|
}
|
|
|
|
// #when
|
|
await hook["tool.execute.before"](input, output)
|
|
|
|
// #then
|
|
expect(output.args.prompt).toBe(originalPrompt)
|
|
expect(output.args.prompt).not.toContain("[SYSTEM DIRECTIVE - READ-ONLY PLANNING CONSULTATION]")
|
|
})
|
|
})
|
|
|
|
describe("without message storage", () => {
|
|
test("should handle missing session gracefully (no agent found)", async () => {
|
|
// #given
|
|
const hook = createPrometheusMdOnlyHook(createMockPluginInput())
|
|
const input = {
|
|
tool: "Write",
|
|
sessionID: "non-existent-session",
|
|
callID: "call-1",
|
|
}
|
|
const output = {
|
|
args: { filePath: "/path/to/file.ts" },
|
|
}
|
|
|
|
// #when / #then
|
|
await expect(
|
|
hook["tool.execute.before"](input, output)
|
|
).resolves.toBeUndefined()
|
|
})
|
|
})
|
|
})
|