* style(tests): normalize BDD comments from '// #given' to '// given'
- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given
* fix(rules-injector): prefer output.metadata.filePath over output.title
- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label
* feat(slashcommand): add optional user_message parameter
- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage
* feat(hooks): restore compaction-context-injector hook
- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry
* refactor(background-agent): split manager.ts into focused modules
- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports
* refactor(agents): split prometheus-prompt.ts into subdirectory
- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports
* refactor(delegate-task): split tools.ts into focused modules
- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns
* refactor(builtin-skills): split skills.ts into individual skill files
- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules
* chore: update import paths and lockfile
- Update prometheus import path after refactor
- Update bun.lock
* fix(tests): complete BDD comment normalization
- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts
---------
Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
171 lines
4.8 KiB
TypeScript
171 lines
4.8 KiB
TypeScript
import { describe, it, expect, mock, spyOn } from "bun:test"
|
|
import type { RunContext, Todo, ChildSession, SessionStatus } from "./types"
|
|
|
|
const createMockContext = (overrides: {
|
|
todo?: Todo[]
|
|
childrenBySession?: Record<string, ChildSession[]>
|
|
statuses?: Record<string, SessionStatus>
|
|
} = {}): RunContext => {
|
|
const {
|
|
todo = [],
|
|
childrenBySession = { "test-session": [] },
|
|
statuses = {},
|
|
} = overrides
|
|
|
|
return {
|
|
client: {
|
|
session: {
|
|
todo: mock(() => Promise.resolve({ data: todo })),
|
|
children: mock((opts: { path: { id: string } }) =>
|
|
Promise.resolve({ data: childrenBySession[opts.path.id] ?? [] })
|
|
),
|
|
status: mock(() => Promise.resolve({ data: statuses })),
|
|
},
|
|
} as unknown as RunContext["client"],
|
|
sessionID: "test-session",
|
|
directory: "/test",
|
|
abortController: new AbortController(),
|
|
}
|
|
}
|
|
|
|
describe("checkCompletionConditions", () => {
|
|
it("returns true when no todos and no children", async () => {
|
|
// given
|
|
spyOn(console, "log").mockImplementation(() => {})
|
|
const ctx = createMockContext()
|
|
const { checkCompletionConditions } = await import("./completion")
|
|
|
|
// when
|
|
const result = await checkCompletionConditions(ctx)
|
|
|
|
// then
|
|
expect(result).toBe(true)
|
|
})
|
|
|
|
it("returns false when incomplete todos exist", async () => {
|
|
// given
|
|
spyOn(console, "log").mockImplementation(() => {})
|
|
const ctx = createMockContext({
|
|
todo: [
|
|
{ id: "1", content: "Done", status: "completed", priority: "high" },
|
|
{ id: "2", content: "WIP", status: "in_progress", priority: "high" },
|
|
],
|
|
})
|
|
const { checkCompletionConditions } = await import("./completion")
|
|
|
|
// when
|
|
const result = await checkCompletionConditions(ctx)
|
|
|
|
// then
|
|
expect(result).toBe(false)
|
|
})
|
|
|
|
it("returns true when all todos completed or cancelled", async () => {
|
|
// given
|
|
spyOn(console, "log").mockImplementation(() => {})
|
|
const ctx = createMockContext({
|
|
todo: [
|
|
{ id: "1", content: "Done", status: "completed", priority: "high" },
|
|
{ id: "2", content: "Skip", status: "cancelled", priority: "medium" },
|
|
],
|
|
})
|
|
const { checkCompletionConditions } = await import("./completion")
|
|
|
|
// when
|
|
const result = await checkCompletionConditions(ctx)
|
|
|
|
// then
|
|
expect(result).toBe(true)
|
|
})
|
|
|
|
it("returns false when child session is busy", async () => {
|
|
// given
|
|
spyOn(console, "log").mockImplementation(() => {})
|
|
const ctx = createMockContext({
|
|
childrenBySession: {
|
|
"test-session": [{ id: "child-1" }],
|
|
"child-1": [],
|
|
},
|
|
statuses: { "child-1": { type: "busy" } },
|
|
})
|
|
const { checkCompletionConditions } = await import("./completion")
|
|
|
|
// when
|
|
const result = await checkCompletionConditions(ctx)
|
|
|
|
// then
|
|
expect(result).toBe(false)
|
|
})
|
|
|
|
it("returns true when all children idle", async () => {
|
|
// given
|
|
spyOn(console, "log").mockImplementation(() => {})
|
|
const ctx = createMockContext({
|
|
childrenBySession: {
|
|
"test-session": [{ id: "child-1" }, { id: "child-2" }],
|
|
"child-1": [],
|
|
"child-2": [],
|
|
},
|
|
statuses: {
|
|
"child-1": { type: "idle" },
|
|
"child-2": { type: "idle" },
|
|
},
|
|
})
|
|
const { checkCompletionConditions } = await import("./completion")
|
|
|
|
// when
|
|
const result = await checkCompletionConditions(ctx)
|
|
|
|
// then
|
|
expect(result).toBe(true)
|
|
})
|
|
|
|
it("returns false when grandchild is busy (recursive)", async () => {
|
|
// given
|
|
spyOn(console, "log").mockImplementation(() => {})
|
|
const ctx = createMockContext({
|
|
childrenBySession: {
|
|
"test-session": [{ id: "child-1" }],
|
|
"child-1": [{ id: "grandchild-1" }],
|
|
"grandchild-1": [],
|
|
},
|
|
statuses: {
|
|
"child-1": { type: "idle" },
|
|
"grandchild-1": { type: "busy" },
|
|
},
|
|
})
|
|
const { checkCompletionConditions } = await import("./completion")
|
|
|
|
// when
|
|
const result = await checkCompletionConditions(ctx)
|
|
|
|
// then
|
|
expect(result).toBe(false)
|
|
})
|
|
|
|
it("returns true when all descendants idle (recursive)", async () => {
|
|
// given
|
|
spyOn(console, "log").mockImplementation(() => {})
|
|
const ctx = createMockContext({
|
|
childrenBySession: {
|
|
"test-session": [{ id: "child-1" }],
|
|
"child-1": [{ id: "grandchild-1" }],
|
|
"grandchild-1": [{ id: "great-grandchild-1" }],
|
|
"great-grandchild-1": [],
|
|
},
|
|
statuses: {
|
|
"child-1": { type: "idle" },
|
|
"grandchild-1": { type: "idle" },
|
|
"great-grandchild-1": { type: "idle" },
|
|
},
|
|
})
|
|
const { checkCompletionConditions } = await import("./completion")
|
|
|
|
// when
|
|
const result = await checkCompletionConditions(ctx)
|
|
|
|
// then
|
|
expect(result).toBe(true)
|
|
})
|
|
})
|