* feat(mcp-oauth): add oauth field to ClaudeCodeMcpServer schema Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * feat(mcp-oauth): add RFC 7591 Dynamic Client Registration * feat(mcp-oauth): add RFC 9728 PRM + RFC 8414 AS discovery * feat(mcp-oauth): add secure token storage with {host}/{resource} key format * feat(mcp-oauth): add dynamic port OAuth callback server * feat(mcp-oauth): add RFC 8707 Resource Indicators * feat(mcp-oauth): implement full-spec McpOAuthProvider * feat(mcp-oauth): add step-up authorization handler * feat(mcp-oauth): integrate authProvider into SkillMcpManager * feat(doctor): add MCP OAuth token status check * feat(cli): add mcp oauth subcommand structure * feat(cli): implement mcp oauth login command * fix(mcp-oauth): address cubic review — security, correctness, and test issues - Remove @ts-nocheck from provider.ts, storage.ts, provider.test.ts - Fix server resource leak on missing code/state (close + reject) - Fix command injection in openBrowser (spawn array args, cross-platform) - Mock McpOAuthProvider in login.test.ts for deterministic CI - Recreate auth provider with merged scopes in step-up flow - Add listAllTokens() for global status listing - Fix logout to accept --server-url for correct token deletion - Support both quoted and unquoted WWW-Authenticate params (RFC 2617) - Save/restore OPENCODE_CONFIG_DIR in storage.test.ts - Fix index.test.ts: vitest → bun:test * fix(mcp-oauth): use explorer instead of cmd /c start on Windows to prevent shell injection * fix(mcp-oauth): address remaining cubic review issues - Add 5-minute timeout to provider callback server to prevent indefinite hangs - Persist client registration from token storage across process restarts - Require --server-url for logout to match token storage key format - Use listTokensByHost for server-specific status lookups - Fix callback-server test to handle promise rejection ordering - Fix provider test port expectations (8912 → 19877) - Fix cli-guide.md duplicate Section 7 numbering - Fix manager test for login-on-missing-tokens behavior * fix(mcp-oauth): address final review issues - P1: Redact token values in status.ts output to prevent credential leakage - P2: Read OAuth error response body before throwing in token exchange - Test: Fix mcp-oauth doctor test to use epoch seconds (not milliseconds) --------- Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com> Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
66 lines
1.8 KiB
TypeScript
66 lines
1.8 KiB
TypeScript
import { describe, it, expect, beforeEach, afterEach, mock } from "bun:test"
|
|
import { existsSync, mkdirSync, rmSync } from "node:fs"
|
|
import { join } from "node:path"
|
|
import { tmpdir } from "node:os"
|
|
import { saveToken } from "../../features/mcp-oauth/storage"
|
|
|
|
const { logout } = await import("./logout")
|
|
|
|
describe("logout command", () => {
|
|
const TEST_CONFIG_DIR = join(tmpdir(), "mcp-oauth-logout-test-" + Date.now())
|
|
let originalConfigDir: string | undefined
|
|
|
|
beforeEach(() => {
|
|
originalConfigDir = process.env.OPENCODE_CONFIG_DIR
|
|
process.env.OPENCODE_CONFIG_DIR = TEST_CONFIG_DIR
|
|
if (!existsSync(TEST_CONFIG_DIR)) {
|
|
mkdirSync(TEST_CONFIG_DIR, { recursive: true })
|
|
}
|
|
})
|
|
|
|
afterEach(() => {
|
|
if (originalConfigDir === undefined) {
|
|
delete process.env.OPENCODE_CONFIG_DIR
|
|
} else {
|
|
process.env.OPENCODE_CONFIG_DIR = originalConfigDir
|
|
}
|
|
if (existsSync(TEST_CONFIG_DIR)) {
|
|
rmSync(TEST_CONFIG_DIR, { recursive: true, force: true })
|
|
}
|
|
})
|
|
|
|
it("returns success code when logout succeeds", async () => {
|
|
// given
|
|
const serverUrl = "https://test-server.example.com"
|
|
saveToken(serverUrl, serverUrl, { accessToken: "test-token" })
|
|
|
|
// when
|
|
const exitCode = await logout("test-server", { serverUrl })
|
|
|
|
// then
|
|
expect(exitCode).toBe(0)
|
|
})
|
|
|
|
it("handles non-existent server gracefully", async () => {
|
|
// given
|
|
const serverName = "non-existent-server"
|
|
|
|
// when
|
|
const exitCode = await logout(serverName, { serverUrl: "https://nonexistent.example.com" })
|
|
|
|
// then
|
|
expect(exitCode).toBe(0)
|
|
})
|
|
|
|
it("returns error when --server-url is not provided", async () => {
|
|
// given
|
|
const serverName = "test-server"
|
|
|
|
// when
|
|
const exitCode = await logout(serverName)
|
|
|
|
// then
|
|
expect(exitCode).toBe(1)
|
|
})
|
|
})
|