fix: allow Prometheus to overwrite .sisyphus/*.md plan files
Add exception in write-existing-file-guard for .sisyphus/*.md files so Prometheus can rewrite plan files without being blocked by the guard. The prometheus-md-only hook (which runs later) still validates that only Prometheus can write to these paths, preserving security. Fixes #1576
This commit is contained in:
@@ -198,9 +198,89 @@ describe("createWriteExistingFileGuardHook", () => {
|
|||||||
//#when
|
//#when
|
||||||
const result = differentHook["tool.execute.before"]?.(input as any, output as any)
|
const result = differentHook["tool.execute.before"]?.(input as any, output as any)
|
||||||
|
|
||||||
|
//#then
|
||||||
|
await expect(result).rejects.toThrow("File already exists. Use edit tool instead.")
|
||||||
|
})
|
||||||
|
|
||||||
|
describe(".sisyphus/*.md exception", () => {
|
||||||
|
test("allows write to existing .sisyphus/plans/plan.md", async () => {
|
||||||
|
//#given
|
||||||
|
const sisyphusDir = path.join(tempDir, ".sisyphus", "plans")
|
||||||
|
fs.mkdirSync(sisyphusDir, { recursive: true })
|
||||||
|
const planFile = path.join(sisyphusDir, "plan.md")
|
||||||
|
fs.writeFileSync(planFile, "# Existing Plan")
|
||||||
|
const input = { tool: "Write", sessionID: "ses_1", callID: "call_1" }
|
||||||
|
const output = { args: { filePath: planFile, content: "# Updated Plan" } }
|
||||||
|
|
||||||
|
//#when
|
||||||
|
const result = hook["tool.execute.before"]?.(input as any, output as any)
|
||||||
|
|
||||||
|
//#then
|
||||||
|
await expect(result).resolves.toBeUndefined()
|
||||||
|
})
|
||||||
|
|
||||||
|
test("allows write to existing .sisyphus/notes.md", async () => {
|
||||||
|
//#given
|
||||||
|
const sisyphusDir = path.join(tempDir, ".sisyphus")
|
||||||
|
fs.mkdirSync(sisyphusDir, { recursive: true })
|
||||||
|
const notesFile = path.join(sisyphusDir, "notes.md")
|
||||||
|
fs.writeFileSync(notesFile, "# Notes")
|
||||||
|
const input = { tool: "Write", sessionID: "ses_1", callID: "call_1" }
|
||||||
|
const output = { args: { filePath: notesFile, content: "# Updated Notes" } }
|
||||||
|
|
||||||
|
//#when
|
||||||
|
const result = hook["tool.execute.before"]?.(input as any, output as any)
|
||||||
|
|
||||||
|
//#then
|
||||||
|
await expect(result).resolves.toBeUndefined()
|
||||||
|
})
|
||||||
|
|
||||||
|
test("allows write to existing .sisyphus/*.md using relative path", async () => {
|
||||||
|
//#given
|
||||||
|
const sisyphusDir = path.join(tempDir, ".sisyphus")
|
||||||
|
fs.mkdirSync(sisyphusDir, { recursive: true })
|
||||||
|
const planFile = path.join(sisyphusDir, "plan.md")
|
||||||
|
fs.writeFileSync(planFile, "# Plan")
|
||||||
|
const input = { tool: "Write", sessionID: "ses_1", callID: "call_1" }
|
||||||
|
const output = { args: { filePath: ".sisyphus/plan.md", content: "# Updated" } }
|
||||||
|
|
||||||
|
//#when
|
||||||
|
const result = hook["tool.execute.before"]?.(input as any, output as any)
|
||||||
|
|
||||||
|
//#then
|
||||||
|
await expect(result).resolves.toBeUndefined()
|
||||||
|
})
|
||||||
|
|
||||||
|
test("blocks write to existing .sisyphus/file.txt (non-markdown)", async () => {
|
||||||
|
//#given
|
||||||
|
const sisyphusDir = path.join(tempDir, ".sisyphus")
|
||||||
|
fs.mkdirSync(sisyphusDir, { recursive: true })
|
||||||
|
const textFile = path.join(sisyphusDir, "file.txt")
|
||||||
|
fs.writeFileSync(textFile, "content")
|
||||||
|
const input = { tool: "Write", sessionID: "ses_1", callID: "call_1" }
|
||||||
|
const output = { args: { filePath: textFile, content: "new content" } }
|
||||||
|
|
||||||
|
//#when
|
||||||
|
const result = hook["tool.execute.before"]?.(input as any, output as any)
|
||||||
|
|
||||||
|
//#then
|
||||||
|
await expect(result).rejects.toThrow("File already exists. Use edit tool instead.")
|
||||||
|
})
|
||||||
|
|
||||||
|
test("blocks write to existing regular file (not in .sisyphus)", async () => {
|
||||||
|
//#given
|
||||||
|
const regularFile = path.join(tempDir, "regular.md")
|
||||||
|
fs.writeFileSync(regularFile, "# Regular")
|
||||||
|
const input = { tool: "Write", sessionID: "ses_1", callID: "call_1" }
|
||||||
|
const output = { args: { filePath: regularFile, content: "# Updated" } }
|
||||||
|
|
||||||
|
//#when
|
||||||
|
const result = hook["tool.execute.before"]?.(input as any, output as any)
|
||||||
|
|
||||||
//#then
|
//#then
|
||||||
await expect(result).rejects.toThrow("File already exists. Use edit tool instead.")
|
await expect(result).rejects.toThrow("File already exists. Use edit tool instead.")
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -20,6 +20,15 @@ export function createWriteExistingFileGuardHook(ctx: PluginInput): Hooks {
|
|||||||
const resolvedPath = isAbsolute(filePath) ? filePath : resolve(ctx.directory, filePath)
|
const resolvedPath = isAbsolute(filePath) ? filePath : resolve(ctx.directory, filePath)
|
||||||
|
|
||||||
if (existsSync(resolvedPath)) {
|
if (existsSync(resolvedPath)) {
|
||||||
|
const isSisyphusMarkdown = resolvedPath.replace(/\\/g, "/").includes("/.sisyphus/") && filePath.endsWith(".md")
|
||||||
|
if (isSisyphusMarkdown) {
|
||||||
|
log("[write-existing-file-guard] Allowing .sisyphus/*.md overwrite", {
|
||||||
|
sessionID: input.sessionID,
|
||||||
|
filePath,
|
||||||
|
})
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
log("[write-existing-file-guard] Blocking write to existing file", {
|
log("[write-existing-file-guard] Blocking write to existing file", {
|
||||||
sessionID: input.sessionID,
|
sessionID: input.sessionID,
|
||||||
filePath,
|
filePath,
|
||||||
|
|||||||
Reference in New Issue
Block a user