From 7cd59e9c0a0576dba71759c7a50bf009c46f68ae Mon Sep 17 00:00:00 2001
From: justsisyphus <sisyphus-dev-ai@users.noreply.github.com>
Date: Fri, 16 Jan 2026 18:47:36 +0900
Subject: [PATCH] feat(toast): show warning only for fallback models
 (inherited/system-default)

category-default is the intended behavior for builtin categories,
not a fallback. Only show toast warning when:
- inherited: model from parent session (custom category without model)
- system-default: OpenCode's global default model

User-defined and category-default are both expected behaviors,
so no warning is needed.
---
 .../task-toast-manager/manager.test.ts        | 23 +++++++++----------
 src/features/task-toast-manager/manager.ts    | 18 +++++++--------
 2 files changed, 20 insertions(+), 21 deletions(-)

diff --git a/src/features/task-toast-manager/manager.test.ts b/src/features/task-toast-manager/manager.test.ts
index 069f18516..0265e53dc 100644
--- a/src/features/task-toast-manager/manager.test.ts
+++ b/src/features/task-toast-manager/manager.test.ts
@@ -144,8 +144,8 @@ describe("TaskToastManager", () => {
   })
 
   describe("model fallback info in toast message", () => {
-    test("should display warning when model falls back to category-default", () => {
-      // #given - a task with model fallback to category-default
+    test("should NOT display warning when model is category-default (normal behavior)", () => {
+      // #given - category-default is the intended behavior, not a fallback
       const task = {
         id: "task_1",
         description: "Task with category default model",
@@ -157,16 +157,15 @@ describe("TaskToastManager", () => {
       // #when - addTask is called
       toastManager.addTask(task)
 
-      // #then - toast should show warning with model info
+      // #then - toast should NOT show warning - category default is expected
       expect(mockClient.tui.showToast).toHaveBeenCalled()
       const call = mockClient.tui.showToast.mock.calls[0][0]
-      expect(call.body.message).toContain("⚠️")
-      expect(call.body.message).toContain("google/gemini-3-pro-preview")
-      expect(call.body.message).toContain("(category default)")
+      expect(call.body.message).not.toContain("⚠️")
+      expect(call.body.message).not.toContain("(category default)")
     })
 
     test("should display warning when model falls back to system-default", () => {
-      // #given - a task with model fallback to system-default
+      // #given - system-default is a fallback (no category default, no user config)
       const task = {
         id: "task_1b",
         description: "Task with system default model",
@@ -178,16 +177,16 @@ describe("TaskToastManager", () => {
       // #when - addTask is called
       toastManager.addTask(task)
 
-      // #then - toast should show warning with model info
+      // #then - toast should show fallback warning
       expect(mockClient.tui.showToast).toHaveBeenCalled()
       const call = mockClient.tui.showToast.mock.calls[0][0]
       expect(call.body.message).toContain("⚠️")
       expect(call.body.message).toContain("anthropic/claude-sonnet-4-5")
-      expect(call.body.message).toContain("(system default)")
+      expect(call.body.message).toContain("(system default fallback)")
     })
 
     test("should display warning when model is inherited from parent", () => {
-      // #given - a task with inherited model
+      // #given - inherited is a fallback (custom category without model definition)
       const task = {
         id: "task_2",
         description: "Task with inherited model",
@@ -199,12 +198,12 @@ describe("TaskToastManager", () => {
       // #when - addTask is called
       toastManager.addTask(task)
 
-      // #then - toast should show warning with inherited model
+      // #then - toast should show fallback warning
       expect(mockClient.tui.showToast).toHaveBeenCalled()
       const call = mockClient.tui.showToast.mock.calls[0][0]
       expect(call.body.message).toContain("⚠️")
       expect(call.body.message).toContain("cliproxy/claude-opus-4-5")
-      expect(call.body.message).toContain("(inherited)")
+      expect(call.body.message).toContain("(inherited from parent)")
     })
 
     test("should not display model info when user-defined", () => {
diff --git a/src/features/task-toast-manager/manager.ts b/src/features/task-toast-manager/manager.ts
index 5cb5a7b18..d993e9d06 100644
--- a/src/features/task-toast-manager/manager.ts
+++ b/src/features/task-toast-manager/manager.ts
@@ -107,16 +107,16 @@ export class TaskToastManager {
 
     const lines: string[] = []
 
-    // Show model fallback warning for the new task if applicable
-    if (newTask.modelInfo && newTask.modelInfo.type !== "user-defined") {
-      const icon = "⚠️"
-      const suffixMap: Partial<Record<ModelFallbackInfo["type"], string>> = {
-        inherited: " (inherited)",
-        "category-default": " (category default)",
-        "system-default": " (system default)",
+    const isFallback = newTask.modelInfo && (
+      newTask.modelInfo.type === "inherited" || newTask.modelInfo.type === "system-default"
+    )
+    if (isFallback) {
+      const suffixMap: Record<"inherited" | "system-default", string> = {
+        inherited: " (inherited from parent)",
+        "system-default": " (system default fallback)",
       }
-      const suffix = suffixMap[newTask.modelInfo.type] ?? ""
-      lines.push(`${icon} Model: ${newTask.modelInfo.model}${suffix}`)
+      const suffix = suffixMap[newTask.modelInfo!.type as "inherited" | "system-default"]
+      lines.push(`⚠️ Model fallback: ${newTask.modelInfo!.model}${suffix}`)
       lines.push("")
     }