From 0a085adcd6ecd0c51b048963b9b21f005faf0759 Mon Sep 17 00:00:00 2001
From: YeonGyu-Kim <code.yeon.gyu@gmail.com>
Date: Sun, 15 Feb 2026 15:10:05 +0900
Subject: [PATCH] fix(test): rewrite SDK reader tests to use mock client
 objects instead of mock.module

---
 .../storage/readers-from-sdk.test.ts          | 98 +++++++++++++++++++
 1 file changed, 98 insertions(+)
 create mode 100644 src/hooks/session-recovery/storage/readers-from-sdk.test.ts

diff --git a/src/hooks/session-recovery/storage/readers-from-sdk.test.ts b/src/hooks/session-recovery/storage/readers-from-sdk.test.ts
new file mode 100644
index 000000000..e3194576f
--- /dev/null
+++ b/src/hooks/session-recovery/storage/readers-from-sdk.test.ts
@@ -0,0 +1,98 @@
+import { describe, expect, it } from "bun:test"
+import { readMessagesFromSDK, readPartsFromSDK } from "../storage"
+import { readMessages } from "./messages-reader"
+import { readParts } from "./parts-reader"
+
+function createMockClient(handlers: {
+  messages?: (sessionID: string) => unknown[]
+  message?: (sessionID: string, messageID: string) => unknown
+}) {
+  return {
+    session: {
+      messages: async (opts: { path: { id: string } }) => {
+        if (handlers.messages) {
+          return { data: handlers.messages(opts.path.id) }
+        }
+        throw new Error("not implemented")
+      },
+      message: async (opts: { path: { id: string; messageID: string } }) => {
+        if (handlers.message) {
+          return { data: handlers.message(opts.path.id, opts.path.messageID) }
+        }
+        throw new Error("not implemented")
+      },
+    },
+  } as unknown
+}
+
+describe("session-recovery storage SDK readers", () => {
+  it("readPartsFromSDK returns empty array when fetch fails", async () => {
+    //#given a client that throws on request
+    const client = createMockClient({}) as Parameters<typeof readPartsFromSDK>[0]
+
+    //#when readPartsFromSDK is called
+    const result = await readPartsFromSDK(client, "ses_test", "msg_test")
+
+    //#then it returns empty array
+    expect(result).toEqual([])
+  })
+
+  it("readPartsFromSDK returns stored parts from SDK response", async () => {
+    //#given a client that returns a message with parts
+    const sessionID = "ses_test"
+    const messageID = "msg_test"
+    const storedParts = [
+      { id: "prt_1", sessionID, messageID, type: "text", text: "hello" },
+    ]
+
+    const client = createMockClient({
+      message: (_sid, _mid) => ({ parts: storedParts }),
+    }) as Parameters<typeof readPartsFromSDK>[0]
+
+    //#when readPartsFromSDK is called
+    const result = await readPartsFromSDK(client, sessionID, messageID)
+
+    //#then it returns the parts
+    expect(result).toEqual(storedParts)
+  })
+
+  it("readMessagesFromSDK normalizes and sorts messages", async () => {
+    //#given a client that returns messages list
+    const sessionID = "ses_test"
+    const client = createMockClient({
+      messages: () => [
+        { id: "msg_b", role: "assistant", time: { created: 2 } },
+        { id: "msg_a", role: "user", time: { created: 1 } },
+        { id: "msg_c" },
+      ],
+    }) as Parameters<typeof readMessagesFromSDK>[0]
+
+    //#when readMessagesFromSDK is called
+    const result = await readMessagesFromSDK(client, sessionID)
+
+    //#then it returns sorted StoredMessageMeta with defaults
+    expect(result).toEqual([
+      { id: "msg_c", sessionID, role: "user", time: { created: 0 } },
+      { id: "msg_a", sessionID, role: "user", time: { created: 1 } },
+      { id: "msg_b", sessionID, role: "assistant", time: { created: 2 } },
+    ])
+  })
+
+  it("readParts returns empty array for nonexistent message", () => {
+    //#given a message ID that has no stored parts
+    //#when readParts is called
+    const parts = readParts("msg_nonexistent")
+
+    //#then it returns empty array
+    expect(parts).toEqual([])
+  })
+
+  it("readMessages returns empty array for nonexistent session", () => {
+    //#given a session ID that has no stored messages
+    //#when readMessages is called
+    const messages = readMessages("ses_nonexistent")
+
+    //#then it returns empty array
+    expect(messages).toEqual([])
+  })
+})