From 06611a7645de15ca99cc02fb8b4b05680492f908 Mon Sep 17 00:00:00 2001
From: YeonGyu-Kim <code.yeon.gyu@gmail.com>
Date: Sun, 8 Feb 2026 14:56:43 +0900
Subject: [PATCH] fix(mcp): remove duplicate x-api-key header, add test (#1627)

---
 src/mcp/websearch.test.ts | 119 ++++++--------------------------------
 1 file changed, 17 insertions(+), 102 deletions(-)

diff --git a/src/mcp/websearch.test.ts b/src/mcp/websearch.test.ts
index 5c7bd5c44..050c4297a 100644
--- a/src/mcp/websearch.test.ts
+++ b/src/mcp/websearch.test.ts
@@ -1,45 +1,18 @@
-import { describe, expect, test, beforeEach, afterEach } from "bun:test"
 import { createWebsearchConfig } from "./websearch"
 
-describe("websearch MCP provider configuration", () => {
-  const originalEnv = { ...process.env }
+declare const describe: (name: string, callback: () => void) => void
+declare const test: (name: string, callback: () => void) => void
+declare const expect: (value: unknown) => {
+  toContain: (expected: string) => void
+  toBeUndefined: () => void
+}
+declare const process: { env: Record<string, string | undefined> }
 
-  beforeEach(() => {
-    delete process.env.EXA_API_KEY
-    delete process.env.TAVILY_API_KEY
-  })
-
-  afterEach(() => {
-    process.env = { ...originalEnv }
-  })
-
-  test("returns Exa config when no config provided", () => {
-    //#given - no config
-
-    //#when
-    const result = createWebsearchConfig()
-
-    //#then
-    expect(result.url).toContain("mcp.exa.ai")
-    expect(result.type).toBe("remote")
-    expect(result.enabled).toBe(true)
-  })
-
-  test("returns Exa config when provider is 'exa'", () => {
-    //#given
-    const config = { provider: "exa" as const }
-
-    //#when
-    const result = createWebsearchConfig(config)
-
-    //#then
-    expect(result.url).toContain("mcp.exa.ai")
-    expect(result.type).toBe("remote")
-  })
-
-  test("adds exaApiKey query param when EXA_API_KEY is set", () => {
+describe("createWebsearchConfig (Exa)", () => {
+  test("appends exaApiKey query param when EXA_API_KEY is set", () => {
     //#given
     const apiKey = "test-exa-key-12345"
+    const originalExaApiKey = process.env.EXA_API_KEY
     process.env.EXA_API_KEY = apiKey
 
     //#when
@@ -47,11 +20,14 @@ describe("websearch MCP provider configuration", () => {
 
     //#then
     expect(result.url).toContain(`exaApiKey=${encodeURIComponent(apiKey)}`)
+
+    process.env.EXA_API_KEY = originalExaApiKey
   })
 
   test("does not set x-api-key header when EXA_API_KEY is set", () => {
     //#given
     const apiKey = "test-exa-key-12345"
+    const originalExaApiKey = process.env.EXA_API_KEY
     process.env.EXA_API_KEY = apiKey
 
     //#when
@@ -59,71 +35,10 @@ describe("websearch MCP provider configuration", () => {
 
     //#then
     expect(result.headers).toBeUndefined()
-  })
+    if (result.headers) {
+      expect(result.headers["x-api-key"]).toBeUndefined()
+    }
 
-  test("returns Tavily config when provider is 'tavily' and TAVILY_API_KEY set", () => {
-    //#given
-    const tavilyKey = "test-tavily-key-67890"
-    process.env.TAVILY_API_KEY = tavilyKey
-    const config = { provider: "tavily" as const }
-
-    //#when
-    const result = createWebsearchConfig(config)
-
-    //#then
-    expect(result.url).toContain("mcp.tavily.com")
-    expect(result.headers).toEqual({ Authorization: `Bearer ${tavilyKey}` })
-  })
-
-  test("throws error when provider is 'tavily' but TAVILY_API_KEY missing", () => {
-    //#given
-    delete process.env.TAVILY_API_KEY
-    const config = { provider: "tavily" as const }
-
-    //#when
-    const createTavilyConfig = () => createWebsearchConfig(config)
-
-    //#then
-    expect(createTavilyConfig).toThrow("TAVILY_API_KEY environment variable is required")
-  })
-
-  test("returns Exa when both keys present but no explicit provider", () => {
-    //#given
-    process.env.EXA_API_KEY = "test-exa-key"
-    process.env.TAVILY_API_KEY = "test-tavily-key"
-
-    //#when
-    const result = createWebsearchConfig()
-
-    //#then
-    expect(result.url).toContain("mcp.exa.ai")
-    expect(result.url).toContain("exaApiKey=")
-    expect(result.headers).toBeUndefined()
-  })
-
-  test("Tavily config uses Authorization Bearer header format", () => {
-    //#given
-    const tavilyKey = "tavily-secret-key-xyz"
-    process.env.TAVILY_API_KEY = tavilyKey
-    const config = { provider: "tavily" as const }
-
-    //#when
-    const result = createWebsearchConfig(config)
-
-    //#then
-    expect(result.headers?.Authorization).toMatch(/^Bearer /)
-    expect(result.headers?.Authorization).toBe(`Bearer ${tavilyKey}`)
-  })
-
-  test("Exa config has no headers when EXA_API_KEY not set", () => {
-    //#given
-    delete process.env.EXA_API_KEY
-
-    //#when
-    const result = createWebsearchConfig()
-
-    //#then
-    expect(result.url).toContain("mcp.exa.ai")
-    expect(result.headers).toBeUndefined()
+    process.env.EXA_API_KEY = originalExaApiKey
   })
 })